Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes and changes #12 #19

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Various fixes and changes #12 #19

merged 2 commits into from
Jan 24, 2024

Conversation

MrMiguel211
Copy link

@MrMiguel211 MrMiguel211 commented Jan 24, 2024

  • Fixed Ruined Shrine Access still playing Beetle fight music after leaving.
  • Changed the 1st Pass Pirates in Research Entrance to be inactive until touching the cutscene trigger.
  • Adjusted the cutscene skip lock-on point in Ruined Shrine to a more accurate position.
  • Added a crash prevention in all elevators related to skipping the arrival cutscene exactly 60 frames before it ends.
  • Removed Ventilation Shaft cutscene skip load wait.

@randovania randovania deleted a comment from MrMiguel211 Jan 24, 2024
@toasterparty
Copy link

Hot tip, you can say Fixes #12 and that issue will automatically close when the PR is merged.

@MrMiguel211
Copy link
Author

Hot tip, you can say Fixes #12 and that issue will automatically close when the PR is merged.

shouldn't it be #19?

@MrMiguel211 MrMiguel211 changed the title Various fixes and changes Various fixes and changes #12 Jan 24, 2024
@toasterparty
Copy link

#12 is the issue I wrote which describes the problem, #19 is this PR.

This PR fixes #12. If Fixes #12 is in the PR description (not the PR title), the thing will happen.

@toasterparty toasterparty merged commit cee6f01 into randovania:main Jan 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants